Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PERF: _propagate_index_objs can be implemented to compute caches #4794

Closed
anmyachev opened this issue Aug 8, 2022 · 1 comment · Fixed by #4888
Closed

PERF: _propagate_index_objs can be implemented to compute caches #4794

anmyachev opened this issue Aug 8, 2022 · 1 comment · Fixed by #4888
Labels
P2 Minor bugs or low-priority feature requests Performance 🚀 Performance related issues and pull requests.

Comments

@anmyachev
Copy link
Collaborator

Place:

modin/modin/core/dataframe/pandas/dataframe/dataframe.py

Line 515 in aeff7ac

def _propagate_index_objs(self, axis=None):

Most likely, we will have to change the interface of add_to_apply_calls function so that it passes caches to the partition constructor.
@anmyachev anmyachev added the Performance 🚀 Performance related issues and pull requests. label Aug 8, 2022
@YarShev
Copy link
Collaborator

YarShev commented Aug 8, 2022

Same applicable to apply. Working on this in YarShev@adb38ca.

anmyachev added a commit to anmyachev/modin that referenced this issue Aug 26, 2022
@anmyachev
PERF-modin-project#4794: Compute caches in '_propagate_index_objs'
39b4509 
Signed-off-by: Myachev <anatoly.myachev@intel.com>
@anmyachev anmyachev mentioned this issue Aug 26, 2022
Merged
8 tasks
@anmyachev anmyachev added the P2 Minor bugs or low-priority feature requests label Aug 29, 2022
YarShev pushed a commit that referenced this issue Aug 31, 2022
@anmyachev @mvashishtha
PERF-#4794: Compute caches in _propagate_index_objs (#4888)
39b36eb 
Co-authored-by: Mahesh Vashishtha <mvashishtha@users.noreply.github.com>
Signed-off-by: Myachev <anatoly.myachev@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P2 Minor bugs or low-priority feature requests Performance 🚀 Performance related issues and pull requests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

PERF-#4794: Compute caches in _propagate_index_objs anmyachev/modin
2 participants
@YarShev @anmyachev