Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PERF: Improve where performance by combining two execution steps into one #4825

Closed
mvashishtha opened this issue Aug 16, 2022 · 1 comment
Closed

PERF: Improve where performance by combining two execution steps into one #4825

mvashishtha opened this issue Aug 16, 2022 · 1 comment
Labels
Performance 🚀 Performance related issues and pull requests.

Comments

@mvashishtha
Copy link
Collaborator

See this note:

modin/modin/core/storage_formats/pandas/query_compiler.py

Lines 414 to 418 in bd326f1

# Note: Currently we are doing this with two maps across the entire
# data. This can be done with a single map, but it will take a
# modification in the `BlockPartition` class.
# If this were in one pass it would be ~2x faster.
# TODO (devin-petersohn) rewrite this to take one pass.

@mvashishtha mvashishtha added the Performance 🚀 Performance related issues and pull requests. label Aug 16, 2022
@mvashishtha mvashishtha mentioned this issue Aug 16, 2022
Merged
8 tasks
mvashishtha pushed a commit to mvashishtha/modin that referenced this issue Aug 31, 2022
FIX-modin-project#4818, PERF-modin-project#4825: Fix where by using t…
4eba3cc 
…he new n-ary operator

Signed-off-by: mvashishtha <mahesh@ponder.io>
RehanSD pushed a commit that referenced this issue Sep 1, 2022
@mvashishtha @vnlitvinov
FIX-#4818, PERF-#4825: Fix where by using the new n-ary operator (#4820)
2660aa3 
Signed-off-by: mvashishtha <mahesh@ponder.io>
Co-authored-by: Vasily Litvinov <fam1ly.n4me@yandex.ru>
@YarShev
Copy link
Collaborator

YarShev commented Sep 2, 2022

Closed in #4820.

@YarShev YarShev closed this as completed Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Performance 🚀 Performance related issues and pull requests.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mvashishtha @YarShev