Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PERF: iloc function that used in partition.mask should be serialized only once #4866

Closed
anmyachev opened this issue Aug 23, 2022 · 0 comments · Fixed by #4901
Closed

PERF: iloc function that used in partition.mask should be serialized only once #4866

anmyachev opened this issue Aug 23, 2022 · 0 comments · Fixed by #4901
Labels
P2 Minor bugs or low-priority feature requests Performance 🚀 Performance related issues and pull requests.

Comments

@anmyachev
Copy link
Collaborator

Place:

modin/modin/core/dataframe/pandas/partitioning/partition.py

Line 188 in cfcdf08

new_obj = self.add_to_apply_calls(lambda df: df.iloc[row_labels, col_labels])

Motivation: partition.mask - one of the most used functions.
@anmyachev anmyachev added Performance 🚀 Performance related issues and pull requests. P2 Minor bugs or low-priority feature requests labels Aug 23, 2022
@anmyachev anmyachev mentioned this issue Aug 30, 2022
Merged
8 tasks
anmyachev added a commit to anmyachev/modin that referenced this issue Aug 30, 2022
@anmyachev
PERF-modin-project#4866: help iloc function should be serialized only…
8ff5326 
… once

Signed-off-by: Myachev <anatoly.myachev@intel.com>
YarShev pushed a commit that referenced this issue Aug 31, 2022
@anmyachev @vnlitvinov
PERF-#4866: iloc function that used in partition.mask should be s…
5ff947b 
…erialized only once (#4901)

Co-authored-by: Vasily Litvinov <fam1ly.n4me@yandex.ru>
Signed-off-by: Myachev <anatoly.myachev@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P2 Minor bugs or low-priority feature requests Performance 🚀 Performance related issues and pull requests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

PERF-#4866: iloc function that used in partition.mask should be serialized only once anmyachev/modin
1 participant
@anmyachev