Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REFACTOR: de-duplicate code #4885

Closed
jbrockmendel opened this issue Aug 25, 2022 · 2 comments
Closed

REFACTOR: de-duplicate code #4885

jbrockmendel opened this issue Aug 25, 2022 · 2 comments
Labels
Code Quality 💯 Improvements or issues to improve quality of codebase P2 Minor bugs or low-priority feature requests

Comments

@jbrockmendel
Copy link
Collaborator

Requiring an issue be created for every PR is a PITA.
@jbrockmendel jbrockmendel added bug 🦗 Something isn't working Triage 🩹 Issues that need triage labels Aug 25, 2022
@pyrito pyrito added P2 Minor bugs or low-priority feature requests Code Quality 💯 Improvements or issues to improve quality of codebase and removed Triage 🩹 Issues that need triage bug 🦗 Something isn't working labels Aug 26, 2022
@pyrito
Copy link
Collaborator

pyrito commented Aug 26, 2022

@jbrockmendel yeah it's a little annoying, but I think it's worth keeping the discipline for now. Maybe as the project grows we can think about relaxing this requirement.

jbrockmendel added a commit to jbrockmendel/modin that referenced this issue Aug 29, 2022
@jbrockmendel
REFACTOR-modin-project#4885: de-duplicate take_2d_labels_or_positiona…
f5af678 
…l methods

Signed-off-by: Brock Mendel <jbrockmendel@gmail.com>
anmyachev pushed a commit that referenced this issue Sep 1, 2022
@jbrockmendel
REFACTOR-#4885: de-duplicate take_2d_labels_or_positional methods (#4883
f2ca8ac 
)

Signed-off-by: Brock Mendel <jbrockmendel@gmail.com>
@Garra1980 Garra1980 changed the title REF: de-duplicate code REFACTOR: de-duplicate code Sep 12, 2022
@mvashishtha mvashishtha mentioned this issue Sep 15, 2022
Closed
@anmyachev
Copy link
Collaborator

Fixed in #4883

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Code Quality 💯 Improvements or issues to improve quality of codebase P2 Minor bugs or low-priority feature requests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jbrockmendel @pyrito @anmyachev