Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: dataframe.attrs is None by default #4993

Closed
3 tasks done
dss010101 opened this issue Sep 18, 2022 · 1 comment · Fixed by #4995
Closed
3 tasks done

BUG: dataframe.attrs is None by default #4993

dss010101 opened this issue Sep 18, 2022 · 1 comment · Fixed by #4995
Assignees
Labels
bug 🦗 Something isn't working P2 Minor bugs or low-priority feature requests pandas concordance 🐼 Functionality that does not match pandas

Comments

@dss010101
Copy link

dss010101 commented Sep 18, 2022

Modin version checks

  • I have checked that this issue has not already been reported.

  • I have confirmed this bug exists on the latest released version of Modin.

  • I have confirmed this bug exists on the main branch of Modin. (In order to do this you can follow this guide.)

Reproducible Example

import modin.pandas as pd
import pandas
mdf = pd.DataFrame()
df = pandas.DataFrame()
print(f'pandas: {df.attrs}, modin: {mdf.attrs}')

>> pandas: {}, modin: None

Issue Description

By default, pandas dataframe.attrs is an dictionary. modin's is None.

Expected Behavior

default for a modin.pandas dataframe should be an empty dictionary

Error Logs

None

Installed Versions

INSTALLED VERSIONS
------------------
commit           : efdfbac86dbe7a1b9028e3877e9f2bc7502b58cf
python           : 3.10.5.final.0
python-bits      : 64
OS               : Windows
OS-release       : 10
Version          : 10.0.19044
machine          : AMD64
processor        : AMD64 Family 23 Model 96 Stepping 1, AuthenticAMD
byteorder        : little
LC_ALL           : None
LANG             : en_US.UTF-8
LOCALE           : English_United States.1252

Modin dependencies
------------------
modin            : 0.15.0
ray              : 3.0.0.dev0
dask             : 2022.9.1
distributed      : None
omniscidbe       : None

pandas dependencies
-------------------
pandas           : 1.4.2
numpy            : 1.23.1
pytz             : 2022.1
dateutil         : 2.8.2
pip              : 22.2.2
setuptools       : 58.1.0
Cython           : None
pytest           : None
hypothesis       : None
sphinx           : None
blosc            : None
feather          : None
xlsxwriter       : None
lxml.etree       : 4.9.1
html5lib         : None
pymysql          : None
psycopg2         : None
jinja2           : 3.1.2
IPython          : 8.4.0
pandas_datareader: 0.10.0
bs4              : 4.11.1
bottleneck       : None
brotli           : None
fastparquet      : None
fsspec           : 2022.8.2
gcsfs            : None
markupsafe       : 2.1.1
matplotlib       : 3.5.2
numba            : None
numexpr          : None
odfpy            : None
openpyxl         : None
pandas_gbq       : None
pyarrow          : 9.0.0
pyreadstat       : None
pyxlsb           : None
s3fs             : None
scipy            : None
snappy           : None
sqlalchemy       : None
tables           : None
tabulate         : None
xarray           : None
xlrd             : 2.0.1
xlwt             : None
zstandard        : None
@dss010101 dss010101 added bug 🦗 Something isn't working Triage 🩹 Issues that need triage labels Sep 18, 2022
@vnlitvinov vnlitvinov added pandas concordance 🐼 Functionality that does not match pandas P2 Minor bugs or low-priority feature requests and removed Triage 🩹 Issues that need triage labels Sep 19, 2022
@vnlitvinov
Copy link
Collaborator

Thanks @MSingh00 for reporting the issue!

I can reproduce it on current master. We'll look into it!

@pyrito pyrito self-assigned this Sep 19, 2022
pyrito pushed a commit to pyrito/modin that referenced this issue Sep 19, 2022
Signed-off-by: Karthik Velayutham <vkarthik@ponder.io>
anmyachev pushed a commit that referenced this issue Sep 19, 2022
Signed-off-by: Karthik Velayutham <vkarthik@ponder.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🦗 Something isn't working P2 Minor bugs or low-priority feature requests pandas concordance 🐼 Functionality that does not match pandas
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants