Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REFACTOR: Add mypy checks for modin.core.dataframe.base #5079

Closed
Tracked by #4630
mvashishtha opened this issue Oct 4, 2022 · 2 comments · Fixed by #5110
Closed
Tracked by #4630

REFACTOR: Add mypy checks for modin.core.dataframe.base #5079

mvashishtha opened this issue Oct 4, 2022 · 2 comments · Fixed by #5110
Assignees
@shalearkane
Labels
Code Quality 💯 Improvements or issues to improve quality of codebase good first issue 🔰 Good for newcomers hacktoberfest Help Wanted 🌐 Issues good for external contributors. P2 Minor bugs or low-priority feature requests

Comments

@mvashishtha
Copy link
Collaborator

No description provided.

@mvashishtha mvashishtha added Code Quality 💯 Improvements or issues to improve quality of codebase P2 Minor bugs or low-priority feature requests good first issue 🔰 Good for newcomers Help Wanted 🌐 Issues good for external contributors. hacktoberfest labels Oct 4, 2022
This was referenced Oct 4, 2022
Open
Open
@shalearkane
Copy link
Contributor

Could you please assign me this issue?

@mvashishtha
Copy link
Collaborator Author

@shalearkane sure. I'm happy to help you merge a PR for this issue. You can follow the instructions here, except replace modin/core/dataframe/algebra with modin/core/dataframe/base.

shalearkane added a commit to shalearkane/modin that referenced this issue Oct 9, 2022
@shalearkane
REFACTOR-modin-project#5079:
0a17128 
- added type hints to functions in modin.core.dataframe.base
- also added "# type: ignore" to abstract methods to ignore non-existent
  class members

Signed-off-by: Soumik Dutta <shalearkane@gmail.com>
@shalearkane shalearkane mentioned this issue Oct 9, 2022
Merged
6 tasks
mvashishtha added a commit that referenced this issue Nov 9, 2022
@shalearkane @mvashishtha
REFACTOR-#5079: Add mypy checks for modin.core.dataframe.base (#5110)
77530c8 
Signed-off-by: Soumik Dutta <shalearkane@gmail.com>
Co-authored-by: Mahesh Vashishtha <mvashishtha@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shalearkane shalearkane

Labels
Code Quality 💯 Improvements or issues to improve quality of codebase good first issue 🔰 Good for newcomers hacktoberfest Help Wanted 🌐 Issues good for external contributors. P2 Minor bugs or low-priority feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

REFACTOR-#5079: Add mypy checks for modin.core.dataframe.base shalearkane/modin
2 participants
@mvashishtha @shalearkane