Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deduplicate code for Ray and Unidist engines #5275

Closed
YarShev opened this issue Nov 28, 2022 · 0 comments · Fixed by #5457
Closed

Deduplicate code for Ray and Unidist engines #5275

YarShev opened this issue Nov 28, 2022 · 0 comments · Fixed by #5457
Assignees
@YarShev
Labels
Code Quality 💯 Improvements or issues to improve quality of codebase P2 Minor bugs or low-priority feature requests

Comments

@YarShev
Copy link
Collaborator

YarShev commented Nov 28, 2022

After #5059 is merged, we will have some duplicate code for both Ray and Unidist engines. We should move some of duplicated code into a common place and use it in all places instead.
@YarShev YarShev added new feature/request 💬 Requests and pull requests for new features Triage 🩹 Issues that need triage Code Quality 💯 Improvements or issues to improve quality of codebase and removed new feature/request 💬 Requests and pull requests for new features Triage 🩹 Issues that need triage labels Nov 28, 2022
@YarShev YarShev mentioned this issue Nov 28, 2022
Merged
7 tasks
@pyrito pyrito added the P2 Minor bugs or low-priority feature requests label Nov 28, 2022
@YarShev YarShev self-assigned this Dec 1, 2022
@YarShev YarShev mentioned this issue Dec 16, 2022
Merged
7 tasks
YarShev added a commit to YarShev/modin that referenced this issue Jan 4, 2023
@YarShev
REFACTOR-modin-project#5275: Deduplicate code for Ray and Unidist eng…
9c266d3 
…ines

Signed-off-by: Igoshev, Iaroslav <iaroslav.igoshev@intel.com>
anmyachev pushed a commit that referenced this issue Jan 11, 2023
@YarShev
REFACTOR-#5275: Deduplicate code for Ray and Unidist engines (#5457)
843b0cf 
Signed-off-by: Igoshev, Iaroslav <iaroslav.igoshev@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@YarShev YarShev

Labels
Code Quality 💯 Improvements or issues to improve quality of codebase P2 Minor bugs or low-priority feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

REFACTOR-#5275: Deduplicate code for Ray and Unidist engines YarShev/modin
2 participants
@pyrito @YarShev