Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not trigger index materialization for .merge() result #5596

Closed
dchigarev opened this issue Jan 30, 2023 · 0 comments · Fixed by #5619
Closed

Do not trigger index materialization for .merge() result #5596

dchigarev opened this issue Jan 30, 2023 · 0 comments · Fixed by #5619
Assignees
@dchigarev
Labels
Performance 🚀 Performance related issues and pull requests.

Comments

@dchigarev
Copy link
Collaborator

Currently, the merge's logic materializes the index of the merged frames just to decide whether it should be dropped or not:

modin/modin/core/storage_formats/pandas/query_compiler.py

Lines 492 to 494 in 4f78260

is_reset_index = not any(
o in new_self.index.names and o in right.index.names for o in on
)

We can decide the same based on the .merge() arguments without materializing the index.
@dchigarev dchigarev added the Performance 🚀 Performance related issues and pull requests. label Jan 30, 2023
@dchigarev dchigarev self-assigned this Jan 30, 2023
dchigarev added a commit to dchigarev/modin that referenced this issue Feb 3, 2023
@dchigarev
PERF-modin-project#5596: Do not trigger index materialization for '.m…
741f15d 
…erge' result

Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
@dchigarev dchigarev mentioned this issue Feb 3, 2023
Merged
7 tasks
YarShev pushed a commit that referenced this issue Feb 9, 2023
@dchigarev
PERF-#5596: Do not trigger index materialization for '.merge' result (#…
209a03c 
…5619)

Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dchigarev dchigarev

Labels
Performance 🚀 Performance related issues and pull requests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

PERF-#5596: Do not trigger index materialization for '.merge' result dchigarev/modin
1 participant
@dchigarev