Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Modin.NumPy __repr__ materializes full data onto head node #5730

Closed
3 tasks done
RehanSD opened this issue Mar 2, 2023 · 0 comments · Fixed by #5731
Closed
3 tasks done

BUG: Modin.NumPy __repr__ materializes full data onto head node #5730

RehanSD opened this issue Mar 2, 2023 · 0 comments · Fixed by #5731
Assignees
Labels
bug 🦗 Something isn't working numpy API Tasks related to modin's implementation of numpy API P0 Highest priority tasks requiring immediate fix

Comments

@RehanSD
Copy link
Collaborator

RehanSD commented Mar 2, 2023

Modin version checks

  • I have checked that this issue has not already been reported.

  • I have confirmed this bug exists on the latest released version of Modin.

  • I have confirmed this bug exists on the main branch of Modin. (In order to do this you can follow this guide.)

Reproducible Example

import modin.numpy as np
arr = np.array([[1, 2], [3, 4], [5, 6]])
arr

Issue Description

repr materializes all of the data onto the head node and relies on NumPy's repr, when we shouldn't be doing that for big arrays. Additionally, we reset index quite frequently (which isn't necessary for non-Pandas storage formats), and try to change types very frequently.

Expected Behavior

Only materialize necessary data to head node.

Error Logs

Replace this line with the error backtrace (if applicable).

Installed Versions

Replace this line with the output of pd.show_versions()

@RehanSD RehanSD added bug 🦗 Something isn't working Triage 🩹 Issues that need triage labels Mar 2, 2023
RehanSD added a commit to RehanSD/modin that referenced this issue Mar 2, 2023
…mpy.array constructor directly

Signed-off-by: Rehan Durrani <rehan@ponder.io>
@RehanSD RehanSD added P0 Highest priority tasks requiring immediate fix and removed Triage 🩹 Issues that need triage labels Mar 2, 2023
@RehanSD RehanSD self-assigned this Mar 2, 2023
@RehanSD RehanSD added the numpy API Tasks related to modin's implementation of numpy API label Mar 2, 2023
devin-petersohn pushed a commit that referenced this issue Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🦗 Something isn't working numpy API Tasks related to modin's implementation of numpy API P0 Highest priority tasks requiring immediate fix
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant