Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: HDK: Binary operations on strings are not supported #5742

Closed
3 tasks done
AndreyPavlenko opened this issue Mar 3, 2023 · 0 comments · Fixed by #5743
Closed
3 tasks done

BUG: HDK: Binary operations on strings are not supported #5742

AndreyPavlenko opened this issue Mar 3, 2023 · 0 comments · Fixed by #5743
Labels
bug 🦗 Something isn't working HDK Related to HDK (OmniSci successor) engine or backend

Comments

@AndreyPavlenko
Copy link
Collaborator

Modin version checks

  • I have checked that this issue has not already been reported.

  • I have confirmed this bug exists on the latest released version of Modin.

  • I have confirmed this bug exists on the main branch of Modin. (In order to do this you can follow this guide.)

Reproducible Example

import modin.pandas as pd
df = pd.DataFrame({"a": ["a"]})
print(df + "_sfx")
print("pref_" + df)
print(df * 10)

Issue Description

Binary operations on strings are not supported by HDK.

Expected Behavior

       a
0  a_sfx
        a
0  pref_a
            a
0  aaaaaaaaaa

Error Logs

modin/experimental/core/execution/native/implementations/hdk_on_native/expr.py", line 59, in _get_common_dtype
    raise TypeError(f"Cannot perform operation on types: {lhs_dtype}, {rhs_dtype}")
TypeError: Cannot perform operation on types: object, <U0

Installed Versions

Replace this line with the output of pd.show_versions()

@AndreyPavlenko AndreyPavlenko added bug 🦗 Something isn't working HDK Related to HDK (OmniSci successor) engine or backend labels Mar 3, 2023
AndreyPavlenko added a commit to AndreyPavlenko/modin that referenced this issue Mar 3, 2023
…t supported

Fall back to pandas in case of binary operations on strings.
Such operations are not supported by HDK.

Signed-off-by: Andrey Pavlenko <andrey.a.pavlenko@gmail.com>
anmyachev pushed a commit that referenced this issue Mar 3, 2023
…5743)

Signed-off-by: Andrey Pavlenko <andrey.a.pavlenko@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🦗 Something isn't working HDK Related to HDK (OmniSci successor) engine or backend
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant