Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add modin_layer names to classes that inherit ClassLogger #7078

Closed
arunjose696 opened this issue Mar 13, 2024 · 0 comments · Fixed by #7099
Closed

Add modin_layer names to classes that inherit ClassLogger #7078

arunjose696 opened this issue Mar 13, 2024 · 0 comments · Fixed by #7099
Labels
new feature/request 💬 Requests and pull requests for new features

Comments

@arunjose696
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. What kind of performance improvements would you like to see with this new API?

Currently the classes such as PandasDataframe, QueryCompiler, PandasDataframePartitionManager etc which inherit ClassLogger dont set the value of _modin_logging_layer so the default value "PANDAS-API" is used everywhere to display logs.

Add the _modin_logging_layer names to different layers so the logging can be slightly more intuitive.
@arunjose696 arunjose696 added the new feature/request 💬 Requests and pull requests for new features label Mar 13, 2024
@arunjose696 arunjose696 mentioned this issue Mar 18, 2024
Merged
7 tasks
YarShev added a commit that referenced this issue Mar 20, 2024
@arunjose696 @YarShev
FEAT-#7078: Add modin_layer names to classes that inherit ClassLogger (…
2df2623 
…#7099)

Co-authored-by: Iaroslav Igoshev <Poolliver868@mail.ru>
Signed-off-by: arunjose696 <arunjose696@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
new feature/request 💬 Requests and pull requests for new features
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

FEAT-#7078: Add modin_layer names to classes that inherit ClassLogger arunjose696/modin
1 participant
@arunjose696