-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCS-#3719: Improve documentation for pandas_on_python
execution
#3775
DOCS-#3719: Improve documentation for pandas_on_python
execution
#3775
Conversation
… execution Signed-off-by: Alexey Prutskov <alexey.prutskov@intel.com>
Codecov Report
@@ Coverage Diff @@
## master #3775 +/- ##
===========================================
- Coverage 85.44% 29.44% -56.00%
===========================================
Files 197 183 -14
Lines 16417 15736 -681
===========================================
- Hits 14027 4633 -9394
- Misses 2390 11103 +8713
Continue to review full report at Codecov.
|
docs/flow/modin/core/execution/python/implementations/pandas_on_python/index.rst
Outdated
Show resolved
Hide resolved
docs/flow/modin/core/execution/python/implementations/pandas_on_python/index.rst
Outdated
Show resolved
Hide resolved
docs/flow/modin/core/execution/python/implementations/pandas_on_python/index.rst
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for clarification!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @prutskov looks good, but I'm having difficulty finding it in the docs: https://modin--3775.org.readthedocs.build/en/3775/index.html
@devin-petersohn The link with generated page is in PR description (I duplicate here: https://modin--3775.org.readthedocs.build/en/3775/flow/modin/core/execution/python/implementations/pandas_on_python/index.html) |
I believe the question is how to get to the page you're making here from the index. |
@devin-petersohn, @vnlitvinov New readthedocs theme makes this path intuitively harder than before 😃 |
I wonder if it's intentional that it's not in the left navbar (along with |
We haven't a doc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@prutskov @vnlitvinov Makes sense, LGTM!
I think we need to add |
Thanks! |
Signed-off-by: Alexey Prutskov alexey.prutskov@intel.com
What do these changes do?
PR adds documentation for
pandas_on_python
execution flow.flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
git commit -s
pandas_on_python
execution #3719docs/developer/architecture.rst
is up-to-dateActual doc build is here: https://modin--3775.org.readthedocs.build/en/3775/flow/modin/core/execution/python/implementations/pandas_on_python/index.html