-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REFACTOR-#4047: Rename cluster
directory to cloud
in examples
#4212
REFACTOR-#4047: Rename cluster
directory to cloud
in examples
#4212
Conversation
… examples Signed-off-by: Igoshev, Yaroslav <yaroslav.igoshev@intel.com>
Codecov Report
@@ Coverage Diff @@
## master #4212 +/- ##
===========================================
- Coverage 86.91% 62.90% -24.02%
===========================================
Files 207 207
Lines 17033 17033
===========================================
- Hits 14804 10714 -4090
- Misses 2229 6319 +4090
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@YarShev please clear conflicts, otherwise LGTM
done |
@devin-petersohn, ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be orchestration
instead of cloud
? I think that name might make more sense.
I think it would probably be a better name for the feature than Modin in the Cloud. We should rename the feature as a whole as part of a separate issue if we really want. For now I think renaming |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @YarShev , let's do the rename in another PR
Signed-off-by: Igoshev, Yaroslav yaroslav.igoshev@intel.com
What do these changes do?
flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
git commit -s
cluster
directory tocloud
in examples #4047docs/development/architecture.rst
is up-to-date