-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX-#4300: Fix Modin Categorical column dtype categories #4276
FIX-#4300: Fix Modin Categorical column dtype categories #4276
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4276 +/- ##
==========================================
+ Coverage 82.67% 89.78% +7.11%
==========================================
Files 207 207
Lines 17052 17049 -3
==========================================
+ Hits 14098 15308 +1210
+ Misses 2954 1741 -1213
Continue to review full report at Codecov.
|
Signed-off-by: Naren Krishna <naren@ponder.io>
a80fabc
to
af6b32e
Compare
Signed-off-by: Naren Krishna <naren@ponder.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, will merge when CI passes
Signed-off-by: Naren Krishna naren@ponder.io
What do these changes do?
Fixes Modin Categorical dtype.
flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
git commit -s
docs/development/architecture.rst
is up-to-date