-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCS-#4466: Recommend GitHub issues over bug_reports@modin.org. #4474
DOCS-#4466: Recommend GitHub issues over bug_reports@modin.org. #4474
Conversation
…in.org. Signed-off-by: mvashishtha <mahesh@ponder.io>
Signed-off-by: mvashishtha <mahesh@ponder.io>
Codecov Report
@@ Coverage Diff @@
## master #4474 +/- ##
==========================================
+ Coverage 86.82% 89.54% +2.71%
==========================================
Files 222 222
Lines 18040 18040
==========================================
+ Hits 15664 16154 +490
+ Misses 2376 1886 -490
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
@mvashishtha need to resolve conflict |
@anmyachev Done. |
Should we also recommend GitHub issues over feature_requests@modin.org? Probably, as part of a separate issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The messages are detailed, but long. Is there a way to make them shorter? Maybe we can remove the clause about checking that the issue already exists?
|
Signed-off-by: mvashishtha <mahesh@ponder.io>
@devin-petersohn I removed the clauses about checking that the issue already exists. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mvashishtha, LGTM! Please resolve conflicts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Looks like the other one got merged first 😄 . I cleared the conflict for you @mvashishtha
Signed-off-by: mvashishtha mahesh@ponder.io
What do these changes do?
flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
git commit -s
docs/development/architecture.rst
is up-to-date