Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOCS-#4628: add to_parquet partial support notes #4648

Merged
merged 4 commits into from
Jul 7, 2022
Merged

DOCS-#4628: add to_parquet partial support notes #4648

merged 4 commits into from
Jul 7, 2022

Conversation

d33bs
Copy link
Contributor

@d33bs d33bs commented Jul 6, 2022 •
edited
Loading

Documentation update to specify Dask vs Ray differences and parallel implementation cases of to_parquet with Ray as per discussion within #4624.

Note: no tests added as update only changes documentation.

  • commit message follows format outlined here
  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves DOCS: Document partial support for to_parquet. #4628
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date
  • added (Issue Number: PR title (PR Number)) and github username to release notes for next major release

@d33bs
DOCS-#4628: add to_parquet partial support notes
2fb362c 
Specify Dask vs Ray differences and parallel implementation cases of to_parquet with Ray as per discussion within #4624.

Signed-off-by: Dave Bunten <dave@bntn.net>
@d33bs d33bs requested a review from a team as a code owner July 6, 2022 03:49
mvashishtha
mvashishtha reviewed Jul 6, 2022
View reviewed changes
Copy link
Collaborator

@mvashishtha mvashishtha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@d33bs thank you so much for this PR! I have left one minor comment.

docs/supported_apis/dataframe_supported.rst Outdated Show resolved Hide resolved
d33bs and others added 2 commits July 6, 2022 20:59
@d33bs @mvashishtha
rewording for clarity
651cd80 
Co-authored-by: Mahesh Vashishtha <mvashishtha@users.noreply.github.com>
@d33bs
table reformatting after reword
61cf4c0
@d33bs
Copy link
Contributor Author

d33bs commented Jul 7, 2022

@d33bs thank you so much for this PR! I have left one minor comment.

@mvashishtha Thank you, I just accepted the changes (much clearer!) and reformatted the table.

mvashishtha
mvashishtha approved these changes Jul 7, 2022
View reviewed changes
Copy link
Collaborator

@mvashishtha mvashishtha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you again for the PR.

RehanSD
RehanSD approved these changes Jul 7, 2022
View reviewed changes
Copy link
Collaborator

@RehanSD RehanSD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @d33bs ! Thank you so much for this PR - it looks great! Approving and merging!

@RehanSD RehanSD merged commit 9b33451 into modin-project:master Jul 7, 2022
@d33bs
Copy link
Contributor Author

d33bs commented Jul 7, 2022

Thank you @mvashishtha and @RehanSD !

@d33bs d33bs deleted the update-to_parquet-support-docs branch July 7, 2022 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RehanSD RehanSD RehanSD approved these changes

@mvashishtha mvashishtha mvashishtha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DOCS: Document partial support for to_parquet.
3 participants
@d33bs @mvashishtha @RehanSD