-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX-#4658: Expand exception handling for read_*
functions from s3 storages
#4659
FIX-#4658: Expand exception handling for read_*
functions from s3 storages
#4659
Conversation
read_csv
from s3 storagesread_*
functions from s3 storages
0aa2078
to
8987a91
Compare
Codecov Report
@@ Coverage Diff @@
## master #4659 +/- ##
==========================================
+ Coverage 86.56% 89.68% +3.11%
==========================================
Files 230 231 +1
Lines 18581 18857 +276
==========================================
+ Hits 16085 16911 +826
+ Misses 2496 1946 -550
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
8987a91
to
318116d
Compare
@prutskov How does pandas handle |
I assume this exception is processed internally in |
@anmyachev, I assume, that #4430 will resolve the problem because #4430 will get rid of using of |
Maybe, but it's not ready for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@prutskov thanks, LGTM!
…ons from s3 storages Signed-off-by: Alexey Prutskov <lehaprutskov@gmail.com>
d953a64
to
27ec41f
Compare
@modin-project/modin-core This PR has green CI and approvements from modin-core. Probably, you can merge this |
…torages (#4659) Signed-off-by: Alexey Prutskov <lehaprutskov@gmail.com> Co-authored-by: Yaroslav Igoshev <Poolliver868@mail.ru>
Signed-off-by: Alexey Prutskov lehaprutskov@gmail.com
What do these changes do?
The PR expand the set of handled exceptions in
read_*
functions from s3 storages byEndpointConnectionError
exceptionflake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
git commit -s
read_csv
throws error during reading from s3 #4658docs/development/architecture.rst
is up-to-date