Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REFACTOR-#4750: Delete BaseDataframeAxisPartition.shuffle. #4751

Merged
merged 2 commits into from
Aug 2, 2022

Conversation

mvashishtha
Copy link
Collaborator

Signed-off-by: mvashishtha mahesh@ponder.io

What do these changes do?

REFACTOR-#4750: Delete BaseDataframeAxisPartition.shuffle.

  • commit message follows format outlined here
  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves REFACTOR: Delete BaseDataframeAxisPartition.shuffle and subclass implementations. #4750
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date
  • added (Issue Number: PR title (PR Number)) and github username to release notes for next major release

@mvashishtha mvashishtha requested a review from a team as a code owner August 1, 2022 20:44
RehanSD
RehanSD previously approved these changes Aug 1, 2022
Copy link
Collaborator

@RehanSD RehanSD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'm assuming whatever used this got deprecated + removed but this was missed? Either way, I don't think it should be used by anything rn, so I think it's fine to delete.

@codecov
Copy link

codecov bot commented Aug 1, 2022

Codecov Report

Merging #4751 (6326250) into master (6326250) will not change coverage.
The diff coverage is n/a.

❗ Current head 6326250 differs from pull request most recent head 2dd823b. Consider uploading reports for the commit 2dd823b to get more accurate results

@@           Coverage Diff           @@
##           master    #4751   +/-   ##
=======================================
  Coverage   85.18%   85.18%           
=======================================
  Files         259      259           
  Lines       19346    19346           
=======================================
  Hits        16480    16480           
  Misses       2866     2866           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

vnlitvinov
vnlitvinov previously approved these changes Aug 2, 2022
Copy link
Collaborator

@vnlitvinov vnlitvinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good find!

pyrito
pyrito previously approved these changes Aug 2, 2022
mvashishtha added 2 commits August 2, 2022 11:24
Signed-off-by: mvashishtha <mahesh@ponder.io>
Signed-off-by: mvashishtha <mahesh@ponder.io>
@mvashishtha
Copy link
Collaborator Author

@RehanSD @vnlitvinov I need re-approval after a rebase.

@YarShev YarShev merged commit ccda567 into modin-project:master Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

REFACTOR: Delete BaseDataframeAxisPartition.shuffle and subclass implementations.
5 participants