-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REFACTOR-#4750: Delete BaseDataframeAxisPartition.shuffle. #4751
REFACTOR-#4750: Delete BaseDataframeAxisPartition.shuffle. #4751
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I'm assuming whatever used this got deprecated + removed but this was missed? Either way, I don't think it should be used by anything rn, so I think it's fine to delete.
Codecov Report
@@ Coverage Diff @@
## master #4751 +/- ##
=======================================
Coverage 85.18% 85.18%
=======================================
Files 259 259
Lines 19346 19346
=======================================
Hits 16480 16480
Misses 2866 2866 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, good find!
Signed-off-by: mvashishtha <mahesh@ponder.io>
Signed-off-by: mvashishtha <mahesh@ponder.io>
2dd823b
bdd12e1
to
2dd823b
Compare
@RehanSD @vnlitvinov I need re-approval after a rebase. |
Signed-off-by: mvashishtha mahesh@ponder.io
What do these changes do?
REFACTOR-#4750: Delete BaseDataframeAxisPartition.shuffle.
flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
git commit -s
docs/development/architecture.rst
is up-to-date