Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REFACTOR-#4774: remove _build_treereduce_func call from _compute_dtypes #4775

Merged
merged 1 commit into from
Aug 5, 2022

Conversation

anmyachev
Copy link
Collaborator

@anmyachev anmyachev commented Aug 4, 2022

Signed-off-by: Myachev anatoly.myachev@intel.com

What do these changes do?

  • commit message follows format outlined here
  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves REFACTOR: remove _build_treereduce_func call from _compute_dtypes #4774
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date
  • added (Issue Number: PR title (PR Number)) and github username to release notes for next major release

…m '_compute_dtypes'

Signed-off-by: Myachev <anatoly.myachev@intel.com>
@codecov
Copy link

codecov bot commented Aug 4, 2022

Codecov Report

Merging #4775 (34cb486) into master (a28e319) will increase coverage by 4.50%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4775      +/-   ##
==========================================
+ Coverage   85.29%   89.80%   +4.50%     
==========================================
  Files         259      260       +1     
  Lines       19346    19627     +281     
==========================================
+ Hits        16502    17626    +1124     
+ Misses       2844     2001     -843     
Impacted Files Coverage Δ
modin/core/dataframe/pandas/dataframe/dataframe.py 94.32% <100.00%> (-0.02%) ⬇️
...ecution/ray/implementations/pandas_on_ray/io/io.py 80.37% <0.00%> (-7.48%) ⬇️
modin/db_conn.py 94.28% <0.00%> (-2.86%) ⬇️
modin/core/storage_formats/pandas/parsers.py 88.92% <0.00%> (-1.54%) ⬇️
modin/logging/config.py 94.59% <0.00%> (-1.30%) ⬇️
modin/experimental/batch/test/test_pipeline.py 100.00% <0.00%> (ø)
modin/pandas/series.py 94.33% <0.00%> (+0.24%) ⬆️
modin/pandas/series_utils.py 99.43% <0.00%> (+0.56%) ⬆️
modin/core/io/text/excel_dispatcher.py 94.01% <0.00%> (+0.85%) ⬆️
...ns/pandas_on_ray/partitioning/partition_manager.py 82.19% <0.00%> (+1.36%) ⬆️
... and 35 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@anmyachev anmyachev marked this pull request as ready for review August 4, 2022 20:23
@anmyachev anmyachev requested a review from a team as a code owner August 4, 2022 20:23
Copy link
Collaborator

@YarShev YarShev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anmyachev, good catch, thanks!

@YarShev YarShev merged commit aeff7ac into modin-project:master Aug 5, 2022
@anmyachev anmyachev deleted the issue4774 branch August 5, 2022 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

REFACTOR: remove _build_treereduce_func call from _compute_dtypes
3 participants