PERF-#4713: Stop overriding the ray MacOS object store size limit. #4792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4792 +/- ##
==========================================
+ Coverage 85.24% 89.86% +4.61%
==========================================
Files 259 260 +1
Lines 19381 19690 +309
==========================================
+ Hits 16522 17694 +1172
+ Misses 2859 1996 -863
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
vnlitvinov
previously approved these changes
Aug 8, 2022
pyrito
previously approved these changes
Aug 8, 2022
jeffreykennethli
previously approved these changes
Aug 9, 2022
vnlitvinov
reviewed
Aug 10, 2022
…ize limit. Signed-off-by: mvashishtha <mahesh@ponder.io>
Signed-off-by: mvashishtha <mahesh@ponder.io>
Signed-off-by: mvashishtha <mahesh@ponder.io>
Signed-off-by: mvashishtha <mahesh@ponder.io>
Signed-off-by: mvashishtha <mahesh@ponder.io>
Signed-off-by: mvashishtha <mahesh@ponder.io>
Signed-off-by: mvashishtha <mahesh@ponder.io>
Co-authored-by: jeffreykennethli <jkli@ponder.io>
Signed-off-by: mvashishtha <mahesh@ponder.io>
Signed-off-by: mvashishtha <mahesh@ponder.io>
mvashishtha
force-pushed
the
4713-accept-ray-object-store-limit
branch
from
f117375
to
bbb0444
Compare
pyrito
previously approved these changes
Aug 10, 2022
YarShev
reviewed
Aug 11, 2022
| @@ -34,6 +35,8 @@ | |||
| ) | |||
| from modin.error_message import ErrorMessage | |||
|
|
|||
| _OBJECT_STORE_TO_SYSTEM_MEMORY_RATIO = 0.6 | |||
There was a problem hiding this comment.
Why is this ratio equal to 0.6?
There was a problem hiding this comment.
It's an arbitrary number that has been around for a long time. It goes back to 3542226 from 2019/01/11.
There was a problem hiding this comment.
I was just wondering why we specified it equal to this number, i.e. is there any heuristic. If someone is aware of that, it would be good to know.
Co-authored-by: Yaroslav Igoshev <Poolliver868@mail.ru>
YarShev
approved these changes
Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
PERF-#4713: Stop overriding the ray MacOS object store size limit.
flake8 modin/ asv_bench/benchmarks scripts/doc_checker.pyblack --check modin/ asv_bench/benchmarks scripts/doc_checker.pygit commit -sdocs/development/architecture.rstis up-to-date