-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REFACTOR-#4796: Introduce constant for __reduced__ column name #4799
Conversation
…n name Signed-off-by: Jonathan Shi <jhshi@ponder.io>
Signed-off-by: Jonathan Shi <jhshi@ponder.io>
Codecov Report
@@ Coverage Diff @@
## master #4799 +/- ##
==========================================
+ Coverage 85.28% 89.87% +4.58%
==========================================
Files 259 260 +1
Lines 19381 19666 +285
==========================================
+ Hits 16530 17674 +1144
+ Misses 2851 1992 -859
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, this seems more readable. What does __reduced__
even mean in this context?
@pyrito The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @noloerino , thank you!
Signed-off-by: Jonathan Shi <jhshi@ponder.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@noloerino I have a minor comment.
@prutskov @modin-project/modin-omnisci we need an omnisci approval. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, LGTM. But I found additional places in different parts of modin with direct using of __reduced__
string. We should change __reduced__
->MODIN_UNNAMED_SERIES_LABEL
everywhere (code/comments, docs, tests) to not worry about this places in the future in case we will want to change string value of MODIN_UNNAMED_SERIES_LABEL
Signed-off-by: Jonathan Shi <jhshi@ponder.io>
@prutskov makes sense, I've replaced it in comments/docs as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional one minor suggestion
Co-authored-by: Alexey Prutskov <lehaprutskov@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @noloerino! LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, left a comment.
a46400a
Co-authored-by: Yaroslav Igoshev <Poolliver868@mail.ru>
Signed-off-by: Jonathan Shi jhshi@ponder.io
What do these changes do?
Adds the
MODIN_UNNAMED_SERIES_LABEL
to replace hardcoded instances of `"reduced" found throughout the codebase.flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
git commit -s
__reduced__
column names #4796docs/development/architecture.rst
is up-to-date