Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX-#4840: Change modin-spreadsheet version for notebook requirements #4841

Merged
merged 3 commits into from
Aug 19, 2022

Conversation

pyrito
Copy link
Collaborator

@pyrito pyrito commented Aug 18, 2022

Signed-off-by: Karthik Velayutham vkarthik@ponder.io

What do these changes do?

  • commit message follows format outlined here
  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves CI: Change modin-spreadsheet version for notebook tests #4840
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date
  • added (Issue Number: PR title (PR Number)) and github username to release notes for next major release

… requirements

Signed-off-by: Karthik Velayutham <vkarthik@ponder.io>
@pyrito pyrito requested a review from a team as a code owner August 18, 2022 20:41
@codecov
Copy link

codecov bot commented Aug 18, 2022

Codecov Report

Merging #4841 (b64ef24) into master (980f126) will increase coverage by 4.85%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4841      +/-   ##
==========================================
+ Coverage   85.34%   90.19%   +4.85%     
==========================================
  Files         265      266       +1     
  Lines       19632    19915     +283     
==========================================
+ Hits        16754    17962    +1208     
+ Misses       2878     1953     -925     
Impacted Files Coverage Δ
modin/logging/config.py 94.59% <0.00%> (-1.30%) ⬇️
modin/experimental/batch/test/test_pipeline.py 100.00% <0.00%> (ø)
modin/pandas/groupby.py 93.77% <0.00%> (+0.23%) ⬆️
modin/pandas/series.py 94.23% <0.00%> (+0.24%) ⬆️
modin/pandas/series_utils.py 99.43% <0.00%> (+0.56%) ⬆️
...odin/core/storage_formats/pandas/query_compiler.py 96.59% <0.00%> (+0.56%) ⬆️
modin/core/io/text/excel_dispatcher.py 94.01% <0.00%> (+0.85%) ⬆️
...ns/pandas_on_ray/partitioning/partition_manager.py 82.19% <0.00%> (+1.36%) ⬆️
modin/core/io/column_stores/parquet_dispatcher.py 96.25% <0.00%> (+2.08%) ⬆️
...tations/pandas_on_python/partitioning/partition.py 93.75% <0.00%> (+2.08%) ⬆️
... and 36 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@YarShev
Copy link
Collaborator

YarShev commented Aug 19, 2022

If the user installs the deps from examples/tutorial/jupyter/execution/pandas_on_*/requirements.txt, it won't work, right? Could you please file an issue for that?

@YarShev YarShev merged commit a07ec9d into modin-project:master Aug 19, 2022
YarShev pushed a commit that referenced this pull request Sep 6, 2022
…#4841)

Signed-off-by: Karthik Velayutham <vkarthik@ponder.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: Change modin-spreadsheet version for notebook tests
3 participants