TEST-#5014: Simplify adding new ASV benchmarks #5015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Myachev <anatoly.myachev@intel.com>
Codecov Report
@@ Coverage Diff @@
## master #5015 +/- ##
==========================================
+ Coverage 84.91% 89.65% +4.74%
==========================================
Files 266 254 -12
Lines 19763 19395 -368
==========================================
+ Hits 16781 17389 +608
+ Misses 2982 2006 -976 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Myachev <anatoly.myachev@intel.com>
anmyachev
force-pushed
the
issue5014
branch
from
b847f37
to
eb75963
Compare
anmyachev
commented
Sep 22, 2022
| @@ -470,7 +470,7 @@ jobs: | |||
|
|
|||
| # check pure pandas | |||
| MODIN_ASV_USE_IMPL=pandas asv run --quick --strict --show-stderr --launch-method=spawn \ | |||
| -b ^benchmarks -b ^io -b ^scalability | tee benchmarks.log | |||
There was a problem hiding this comment.
These benchmarks are supposed to be run only for modin, since they do not make sense for pandas.
Garra1980
approved these changes
Sep 23, 2022
YarShev
approved these changes
Sep 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Myachev anatoly.myachev@intel.com
What do these changes do?
Now, when adding benchmarks, there is no need to use predefined functions for benchmarks to work in two modes: pandas and modin. It is enough to use
IMPLvariable instead of importmodin.pandasorpandas.flake8 modin/ asv_bench/benchmarks scripts/doc_checker.pyblack --check modin/ asv_bench/benchmarks scripts/doc_checker.pygit commit -sdocs/development/architecture.rstis up-to-date