FIX-#4966: Fix to_timedelta to return Series instead of TimedeltaIndex
#5028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvashishtha
reviewed
Sep 23, 2022
Codecov Report
@@ Coverage Diff @@
## master #5028 +/- ##
===========================================
- Coverage 84.78% 74.48% -10.31%
===========================================
Files 253 254 +1
Lines 19133 19428 +295
===========================================
- Hits 16222 14470 -1752
- Misses 2911 4958 +2047
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
pyrito
reviewed
Sep 23, 2022
@Billy2551 I recommend running locally the docstyle command from the failed CI job: python scripts/doc_checker.py --add-ignore=D101,D102,D103,D105 --disable-numpydoc \
modin/pandas/dataframe.py modin/pandas/series.py \
modin/pandas/groupby.py \
modin/pandas/series_utils.py modin/pandas/general.py \
modin/pandas/plotting.py modin/pandas/utils.py \
modin/pandas/iterator.py modin/pandas/indexing.py \ |
vnlitvinov
reviewed
Sep 26, 2022
billiam-wang
force-pushed
the
bill-timedelta
branch
from
403dfc0
to
167948a
Compare
pyrito
reviewed
Sep 27, 2022
mvashishtha
reviewed
Sep 28, 2022
mvashishtha
previously approved these changes
Sep 28, 2022
pyrito
previously approved these changes
Sep 28, 2022
…TimedeltaIndex Signed-off-by: Bill Wang <billiam@ponder.io>
billiam-wang
dismissed stale reviews from pyrito and mvashishtha
via
591b7b3
billiam-wang
force-pushed
the
bill-timedelta
branch
from
9b01af1
to
591b7b3
Compare
vnlitvinov
requested changes
Sep 30, 2022
mvashishtha
previously approved these changes
Sep 30, 2022
There was a problem hiding this comment.
@Billy2551 I have a minor comment, but LGTM once @vnlitvinov 's comments are resolved.
pyrito
previously approved these changes
Sep 30, 2022
vnlitvinov
previously approved these changes
Sep 30, 2022
YarShev
dismissed stale reviews from vnlitvinov, pyrito, and mvashishtha
via
8923ae3
YarShev
approved these changes
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bill Wang billiam@ponder.io
What do these changes do?
Added implementation for
to_timedeltainstead of using pandas version. Previously returned incorrect output when using a Modin Series as input.Added tests for
to_timedeltawith Modin Series.flake8 modin/ asv_bench/benchmarks scripts/doc_checker.pyblack --check modin/ asv_bench/benchmarks scripts/doc_checker.pygit commit -sdocs/development/architecture.rstis up-to-date