Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX-#5042: Fix series __getitem__ with invalid strings. #5048

Merged

Conversation

mvashishtha
Copy link
Collaborator

What do these changes do?

FIX-#5042: Fix the error message from series getitem for invalid strings.

  • commit message follows format outlined here
  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves BUG: series.__getitem__(invalid_string) raises UFuncTypeError instead of KeyError #5042
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date
  • added (Issue Number: PR title (PR Number)) and github username to release notes for next major release

@mvashishtha mvashishtha requested a review from a team as a code owner September 28, 2022 05:36
@codecov
Copy link

codecov bot commented Sep 28, 2022

Codecov Report

Merging #5048 (50b1614) into master (2d21561) will increase coverage by 4.70%.
The diff coverage is 84.61%.

❗ Current head 50b1614 differs from pull request most recent head 9953432. Consider uploading reports for the commit 9953432 to get more accurate results

@@            Coverage Diff             @@
##           master    #5048      +/-   ##
==========================================
+ Coverage   84.98%   89.69%   +4.70%     
==========================================
  Files         253      254       +1     
  Lines       19124    19410     +286     
==========================================
+ Hits        16253    17409    +1156     
+ Misses       2871     2001     -870     
Impacted Files Coverage Δ
modin/pandas/series.py 94.53% <84.61%> (+0.49%) ⬆️
modin/logging/config.py 94.59% <0.00%> (-1.30%) ⬇️
modin/experimental/batch/test/test_pipeline.py 93.84% <0.00%> (ø)
modin/pandas/groupby.py 93.77% <0.00%> (+0.23%) ⬆️
modin/pandas/series_utils.py 98.89% <0.00%> (+0.55%) ⬆️
...odin/core/storage_formats/pandas/query_compiler.py 96.40% <0.00%> (+0.55%) ⬆️
modin/core/io/text/excel_dispatcher.py 94.01% <0.00%> (+0.85%) ⬆️
modin/core/io/column_stores/parquet_dispatcher.py 96.25% <0.00%> (+2.08%) ⬆️
...dataframe/pandas/partitioning/partition_manager.py 89.18% <0.00%> (+2.40%) ⬆️
... and 35 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

pyrito
pyrito previously approved these changes Sep 28, 2022
Copy link
Collaborator

@pyrito pyrito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for the fix!

modin/pandas/series.py Outdated Show resolved Hide resolved
mvashishtha and others added 5 commits September 30, 2022 08:49
Signed-off-by: mvashishtha <mahesh@ponder.io>
Signed-off-by: mvashishtha <mahesh@ponder.io>
Signed-off-by: mvashishtha <mahesh@ponder.io>
Signed-off-by: mvashishtha <mahesh@ponder.io>
Co-authored-by: Vasily Litvinov <fam1ly.n4me@yandex.ru>
Copy link
Collaborator

@vnlitvinov vnlitvinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vnlitvinov vnlitvinov merged commit 16d3528 into modin-project:master Oct 3, 2022
@pyrito pyrito mentioned this pull request Oct 5, 2022
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: series.__getitem__(invalid_string) raises UFuncTypeError instead of KeyError
3 participants