Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEST-#5066: add outer join case for TimeConcat benchmark #5067

Merged
merged 1 commit into from
Sep 30, 2022

Conversation

anmyachev
Copy link
Collaborator

@anmyachev anmyachev commented Sep 29, 2022

Signed-off-by: Myachev anatoly.myachev@intel.com

What do these changes do?

  • commit message follows format outlined here
  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves BENCH: add outer join case for TimeConcat benchmark #5066
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date
  • added (Issue Number: PR title (PR Number)) and github username to release notes for next major release

Signed-off-by: Myachev <anatoly.myachev@intel.com>
@codecov
Copy link

codecov bot commented Sep 29, 2022

Codecov Report

Merging #5067 (8353bc4) into master (12c3f14) will increase coverage by 19.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #5067       +/-   ##
===========================================
+ Coverage   70.60%   89.62%   +19.01%     
===========================================
  Files         253      254        +1     
  Lines       19124    19407      +283     
===========================================
+ Hits        13503    17394     +3891     
+ Misses       5621     2013     -3608     
Impacted Files Coverage Δ
modin/logging/config.py 94.59% <0.00%> (-1.30%) ⬇️
modin/experimental/batch/test/test_pipeline.py 90.21% <0.00%> (ø)
modin/pandas/base.py 95.31% <0.00%> (+0.18%) ⬆️
modin/pandas/dataframe.py 91.81% <0.00%> (+0.21%) ⬆️
modin/core/io/text/text_file_dispatcher.py 97.42% <0.00%> (+0.32%) ⬆️
modin/core/dataframe/pandas/dataframe/dataframe.py 95.23% <0.00%> (+0.47%) ⬆️
modin/pandas/series.py 94.27% <0.00%> (+0.47%) ⬆️
modin/pandas/series_utils.py 98.89% <0.00%> (+0.55%) ⬆️
...odin/core/storage_formats/pandas/query_compiler.py 96.40% <0.00%> (+0.55%) ⬆️
modin/pandas/indexing.py 91.42% <0.00%> (+0.71%) ⬆️
... and 75 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@anmyachev anmyachev marked this pull request as ready for review September 30, 2022 08:55
@anmyachev anmyachev requested a review from a team as a code owner September 30, 2022 08:55
@YarShev YarShev merged commit 7d7e38b into modin-project:master Sep 30, 2022
@anmyachev anmyachev deleted the issue5066 branch November 28, 2022 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BENCH: add outer join case for TimeConcat benchmark
2 participants