Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT-#5120: Update to pyhdk 0.2 #5121

Merged
merged 1 commit into from
Oct 13, 2022

Conversation

AndreyPavlenko
Copy link
Collaborator

What do these changes do?

  • commit message follows format outlined here
  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves Update to pyhdk 0.2 #5120?
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

Signed-off-by: Andrey Pavlenko <andrey.a.pavlenko@gmail.com>
@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Merging #5121 (f5e308c) into master (88f7b27) will increase coverage by 5.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5121      +/-   ##
==========================================
+ Coverage   84.56%   89.65%   +5.08%     
==========================================
  Files         256      257       +1     
  Lines       19349    19632     +283     
==========================================
+ Hits        16363    17601    +1238     
+ Misses       2986     2031     -955     
Impacted Files Coverage Δ
modin/logging/config.py 94.59% <0.00%> (-1.30%) ⬇️
modin/experimental/batch/test/test_pipeline.py 93.84% <0.00%> (ø)
modin/core/dataframe/pandas/dataframe/dataframe.py 95.35% <0.00%> (+0.11%) ⬆️
modin/pandas/series.py 94.51% <0.00%> (+0.23%) ⬆️
modin/pandas/base.py 95.25% <0.00%> (+0.26%) ⬆️
...odin/core/storage_formats/pandas/query_compiler.py 96.33% <0.00%> (+0.39%) ⬆️
modin/pandas/series_utils.py 98.89% <0.00%> (+0.55%) ⬆️
modin/core/io/text/excel_dispatcher.py 94.01% <0.00%> (+0.85%) ⬆️
modin/pandas/groupby.py 93.83% <0.00%> (+0.94%) ⬆️
modin/core/io/column_stores/parquet_dispatcher.py 96.25% <0.00%> (+2.08%) ⬆️
... and 37 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AndreyPavlenko AndreyPavlenko marked this pull request as ready for review October 12, 2022 16:21
@AndreyPavlenko AndreyPavlenko requested a review from a team as a code owner October 12, 2022 16:21
Copy link
Collaborator

@pyrito pyrito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you're running into a flake with conda. Could you re-run the jobs?

@YarShev YarShev merged commit f241ee0 into modin-project:master Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to pyhdk 0.2
3 participants