Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX-#5168: module 'collections' has no attribute 'Sequence' in dataframe protocol #5169

Merged
merged 1 commit into from
Nov 2, 2022
Merged

FIX-#5168: module 'collections' has no attribute 'Sequence' in dataframe protocol #5169

merged 1 commit into from
Nov 2, 2022

Conversation

noloerino
Copy link
Collaborator

@noloerino noloerino commented Nov 1, 2022 •
edited
Loading

Signed-off-by: Jonathan Shi jhshi@ponder.io

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves BUG: AttributeError: module 'collections' has no attribute 'Sequence' in dataframe protocol #5168
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@noloerino noloerino marked this pull request as ready for review November 1, 2022 00:53
@noloerino noloerino requested review from a team as code owners November 1, 2022 00:53
mvashishtha
mvashishtha previously approved these changes Nov 1, 2022
View reviewed changes
Copy link
Collaborator

@mvashishtha mvashishtha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@noloerino thank you for the fix. test-ubuntu[ray] seemed to get stuck, so I cancelled it, but it's not stopping.

@noloerino
FIX-modin-project#5168: module 'collections' has no attribute 'Sequen…
02f578c 
…ce' in dataframe protocol

Signed-off-by: Jonathan Shi <jhshi@ponder.io>
@mvashishtha
Copy link
Collaborator

@modin-project/modin-hdk need your approval for this PR?

vnlitvinov
vnlitvinov approved these changes Nov 2, 2022
View reviewed changes
Copy link
Collaborator

@vnlitvinov vnlitvinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vnlitvinov vnlitvinov merged commit ee6c6ae into modin-project:master Nov 2, 2022
@noloerino noloerino deleted the collections-sequence branch November 7, 2022 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vnlitvinov vnlitvinov vnlitvinov approved these changes

@mvashishtha mvashishtha mvashishtha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: AttributeError: module 'collections' has no attribute 'Sequence' in dataframe protocol
3 participants
@noloerino @mvashishtha @vnlitvinov