Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX-#5188: Fix getitem_bool when the key is Series with empty partition #5189

Merged
merged 2 commits into from
Nov 4, 2022
Merged

FIX-#5188: Fix getitem_bool when the key is Series with empty partition #5189

merged 2 commits into from
Nov 4, 2022

Conversation

YarShev
Copy link
Collaborator

@YarShev YarShev commented Nov 3, 2022

Signed-off-by: Igoshev, Iaroslav iaroslav.igoshev@intel.com

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves BUG: KeyError: "None of [Index([()], dtype='object')] are in the [columns]" #5188
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@YarShev
FIX-modin-project#5188: Fix getitem_bool when the key is Series with …
f327452 
…empty partition

Signed-off-by: Igoshev, Iaroslav <iaroslav.igoshev@intel.com>
@YarShev YarShev marked this pull request as ready for review November 3, 2022 16:28
@YarShev YarShev requested a review from a team as a code owner November 3, 2022 16:28
@YarShev
Address comment
1d9fe94 
Signed-off-by: Igoshev, Iaroslav <iaroslav.igoshev@intel.com>
@lgtm-com
Copy link

lgtm-com bot commented Nov 3, 2022

This pull request fixes 1 alert when merging 1d9fe94 into 3a9c48b - view on LGTM.com

fixed alerts:

  • 1 for Unhashable object hashed

@dchigarev dchigarev merged commit c30ab4c into modin-project:master Nov 4, 2022
dchigarev pushed a commit to dchigarev/modin that referenced this pull request Nov 14, 2022
@YarShev @dchigarev
FIX-modin-project#5188: Fix getitem_bool when the key is Series wit…
6eb3277 
…h empty partition (modin-project#5189)

Signed-off-by: Igoshev, Iaroslav <iaroslav.igoshev@intel.com>
@YarShev YarShev deleted the dev/yigoshev-issue5188 branch November 2, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dchigarev dchigarev dchigarev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: KeyError: "None of [Index([()], dtype='object')] are in the [columns]"
2 participants
@YarShev @dchigarev