Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX-#5238: Make rmul really rmul instead of mul. #5246

Merged
merged 3 commits into from
Nov 29, 2022
Merged

FIX-#5238: Make rmul really rmul instead of mul. #5246

merged 3 commits into from
Nov 29, 2022

Conversation

mvashishtha
Copy link
Collaborator

Signed-off-by: mvashishtha mahesh@ponder.io

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves BUG: rmul and mul are treated the same, which is wrong for non-commutative multiplication #5238
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@mvashishtha mvashishtha requested a review from a team as a code owner November 21, 2022 15:29
pyrito
pyrito previously approved these changes Nov 21, 2022
View reviewed changes
vnlitvinov
vnlitvinov requested changes Nov 22, 2022
View reviewed changes
Copy link
Collaborator

@vnlitvinov vnlitvinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make tests clean

modin/pandas/test/dataframe/test_binary.py Show resolved Hide resolved
modin/pandas/test/dataframe/test_binary.py Outdated Show resolved Hide resolved
modin/pandas/test/test_series.py Outdated Show resolved Hide resolved
vnlitvinov
vnlitvinov previously approved these changes Nov 23, 2022
View reviewed changes
Copy link
Collaborator

@vnlitvinov vnlitvinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, left some comments which aren't showstoppers for merging (hence approving).

modin/pandas/base.py Show resolved Hide resolved
modin/pandas/dataframe.py Show resolved Hide resolved
modin/pandas/series.py Show resolved Hide resolved
modin/pandas/test/test_series.py Show resolved Hide resolved
mvashishtha added 3 commits November 23, 2022 23:19
FIX-modin-project#5238: Make rmul really rmul instead of mul.
40ea23a 
Signed-off-by: mvashishtha <mahesh@ponder.io>
Remove bad diff resolve.
4bcf708 
Signed-off-by: mvashishtha <mahesh@ponder.io>
Separate tests of the new class.
eb44e37 
Signed-off-by: mvashishtha <mahesh@ponder.io>
@mvashishtha
Copy link
Collaborator Author

@vnlitvinov I think this is ready for merge

vnlitvinov
vnlitvinov approved these changes Nov 29, 2022
View reviewed changes
Copy link
Collaborator

@vnlitvinov vnlitvinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@vnlitvinov vnlitvinov merged commit b103735 into modin-project:master Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YarShev YarShev YarShev left review comments

@pyrito pyrito pyrito approved these changes

@vnlitvinov vnlitvinov vnlitvinov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: rmul and mul are treated the same, which is wrong for non-commutative multiplication
4 participants
@mvashishtha @pyrito @YarShev @vnlitvinov