-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX-#5277: fix internal execute
function
#5278
Conversation
Signed-off-by: Myachev <anatoly.myachev@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a test to verify that the execute()
call "waits" for all of the partitions?
Co-authored-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
It is much more difficult to write a test if we use UPD: Although no, the same one mock object |
execute
function
@dchigarev test is added |
Signed-off-by: Myachev <anatoly.myachev@intel.com>
@dchigarev ready for merge |
Signed-off-by: Myachev anatoly.myachev@intel.com
What do these changes do?
flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
git commit -s
execute()
function that is supposed to trigger execution actually doesn't do so #5277docs/development/architecture.rst
is up-to-date