Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX-#5277: fix internal execute function #5278

Merged
merged 5 commits into from
Dec 1, 2022

Conversation

anmyachev
Copy link
Collaborator

@anmyachev anmyachev commented Nov 28, 2022

Signed-off-by: Myachev anatoly.myachev@intel.com

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves BUG: the execute() function that is supposed to trigger execution actually doesn't do so #5277
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

Signed-off-by: Myachev <anatoly.myachev@intel.com>
@anmyachev anmyachev marked this pull request as ready for review November 28, 2022 23:34
@anmyachev anmyachev requested a review from a team as a code owner November 28, 2022 23:34
Copy link
Collaborator

@dchigarev dchigarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test to verify that the execute() call "waits" for all of the partitions?

asv_bench/benchmarks/utils/common.py Outdated Show resolved Hide resolved
Co-authored-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
@anmyachev
Copy link
Collaborator Author

anmyachev commented Nov 30, 2022

Can we add a test to verify that the execute() call "waits" for all of the partitions?

It is much more difficult to write a test if we use wait_partitions function.

UPD: Although no, the same one mock object

Signed-off-by: Myachev <anatoly.myachev@intel.com>
Signed-off-by: Myachev <anatoly.myachev@intel.com>
@anmyachev anmyachev changed the title FIX-#5277: fix execute function FIX-#5277: fix eexecute function Nov 30, 2022
@anmyachev anmyachev changed the title FIX-#5277: fix eexecute function FIX-#5277: fix internal execute function Nov 30, 2022
@anmyachev
Copy link
Collaborator Author

@dchigarev test is added

Signed-off-by: Myachev <anatoly.myachev@intel.com>
@anmyachev
Copy link
Collaborator Author

@dchigarev ready for merge

@dchigarev dchigarev merged commit e059238 into modin-project:master Dec 1, 2022
@anmyachev anmyachev deleted the issue5277 branch December 1, 2022 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: the execute() function that is supposed to trigger execution actually doesn't do so
3 participants