Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REFACTOR-#5299: Variable defined multiple times error found by CodeQL #5300

Merged
merged 2 commits into from
Dec 6, 2022

Conversation

anmyachev
Copy link
Collaborator

@anmyachev anmyachev commented Dec 1, 2022

Signed-off-by: Myachev anatoly.myachev@intel.com

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves REFACTOR: Variable defined multiple times error found by CodeQL #5299
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

Signed-off-by: Myachev <anatoly.myachev@intel.com>
@anmyachev anmyachev requested a review from a team as a code owner December 1, 2022 23:44
@lgtm-com
Copy link

lgtm-com bot commented Dec 2, 2022

This pull request fixes 3 alerts when merging 1483e72 into 68b1f86 - view on LGTM.com

fixed alerts:

  • 3 for Variable defined multiple times

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. It looks like GitHub code scanning with CodeQL is already set up for this repo, so no further action is needed 🚀. For more information, please check out our post on the GitHub blog.

Signed-off-by: Myachev <anatoly.myachev@intel.com>
@lgtm-com
Copy link

lgtm-com bot commented Dec 2, 2022

This pull request fixes 3 alerts when merging 866c755 into 123d8e9 - view on LGTM.com

fixed alerts:

  • 3 for Variable defined multiple times

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. It looks like GitHub code scanning with CodeQL is already set up for this repo, so no further action is needed 🚀. For more information, please check out our post on the GitHub blog.

@YarShev YarShev merged commit fa3e4c8 into modin-project:master Dec 6, 2022
@anmyachev anmyachev deleted the issue5299 branch March 24, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

REFACTOR: Variable defined multiple times error found by CodeQL
3 participants