Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REFACTOR-#5335: remove unnecessary lambdas #5336

Merged
merged 1 commit into from
Dec 3, 2022
Merged

REFACTOR-#5335: remove unnecessary lambdas #5336

merged 1 commit into from
Dec 3, 2022

Conversation

anmyachev
Copy link
Collaborator

@anmyachev anmyachev commented Dec 3, 2022 •
edited
Loading

Signed-off-by: Myachev anatoly.myachev@intel.com

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves Fix code scanning alert - Unnecessary lambda #5335
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@anmyachev
REFACTOR-modin-project#5335: remove unnecessary lambdas
229fd3d 
Signed-off-by: Myachev <anatoly.myachev@intel.com>
@anmyachev anmyachev marked this pull request as ready for review December 3, 2022 21:32
@anmyachev anmyachev requested review from a team as code owners December 3, 2022 21:32
mvashishtha
mvashishtha approved these changes Dec 3, 2022
View reviewed changes
Copy link
Collaborator

@mvashishtha mvashishtha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @anmyachev

@mvashishtha mvashishtha merged commit ca0b35c into modin-project:master Dec 3, 2022
@anmyachev anmyachev deleted the issue5335 branch December 3, 2022 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvashishtha mvashishtha mvashishtha approved these changes

Assignees
No one assigned
Labels
Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix code scanning alert - Unnecessary lambda
2 participants
@anmyachev @mvashishtha