Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX-#5325: fix read_csv_glob with non-empty parse_dates dict #5339

Merged
merged 1 commit into from
Dec 5, 2022
Merged

FIX-#5325: fix read_csv_glob with non-empty parse_dates dict #5339

merged 1 commit into from
Dec 5, 2022

Conversation

anmyachev
Copy link
Collaborator

@anmyachev anmyachev commented Dec 3, 2022 •
edited
Loading

Signed-off-by: Myachev anatoly.myachev@intel.com

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves BUG: read_csv_glob raises KeyError for non-empty parse_dates dict #5325
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@anmyachev
FIX-modin-project#5325: fix read_csv_glob with non-empty parse_dates …
de8ef56 
…dict

Signed-off-by: Myachev <anatoly.myachev@intel.com>
@anmyachev anmyachev marked this pull request as ready for review December 3, 2022 22:50
@anmyachev anmyachev requested a review from a team as a code owner December 3, 2022 22:50
anmyachev
anmyachev commented Dec 3, 2022
View reviewed changes
modin/core/io/text/csv_glob_dispatcher.py
empty_pd_df = pandas.read_csv(
filepath_or_buffer, **dict(kwargs, nrows=0, skipfooter=0)
pd_df_metadata = pandas.read_csv(
filepath_or_buffer, **dict(kwargs, nrows=1, skipfooter=0)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aligns with read_csv.

@anmyachev anmyachev changed the title FIX-#5325: fix read_csv_glob with non-empty parse_dates dict FIX-#5325: fix read_csv_glob with non-empty parse_dates dict Dec 3, 2022
@anmyachev
Copy link
Collaborator Author

@mvashishtha could we merge it?

@mvashishtha mvashishtha merged commit b09aeed into modin-project:master Dec 5, 2022
@anmyachev anmyachev deleted the issue5325 branch March 24, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvashishtha mvashishtha mvashishtha approved these changes

Assignees
No one assigned
Labels
Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: read_csv_glob raises KeyError for non-empty parse_dates dict
2 participants
@anmyachev @mvashishtha