Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT-#5423: Add a NumPy API to Modin #5422
FEAT-#5423: Add a NumPy API to Modin #5422
Changes from 9 commits
6f2a6d7
7a4fa99
2a08cf0
4b68f50
0b915b4
9c7a66b
1c6d708
30171d2
ab0ecdb
25510bc
4ef400f
43e3bb5
4301b9d
5ceca02
ff9045c
4b174de
bd2fe98
2a87a39
d513b03
d8d0d10
7404cb3
0d3be93
508ecb3
90aaed7
88aa6b5
e0fb8ce
db3db83
f176ac8
c0a1ecc
e706796
23fe0c4
22b01e0
52f0928
cfaa066
f9be32d
48967d8
5b1da61
74ed3a2
3244b79
a3d57fe
18588b8
19acf64
1bf6c00
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't this be an
assert self._ndim == 2
here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also needs a case for
_ndim == 0
:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now, we're only focusing on 1D and 2D cases @noloerino. @vnlitvinov why would we need this assert?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To immediately know something is not behaving the way we expected. That scalar is an awesome example - a user can feed a scalar and receive some cryptic error message instead of somewhat clear assertion (with a pinpointed place of erroring out to boot).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me - I'll go ahead and add it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you put this assert in? I don't see it in this version of the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the assert in the init. Does that work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, that's fine