Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REFACTOR-#5458: Make deploy functions in virtual_partition.py files private #5455

Merged
merged 1 commit into from
Dec 16, 2022
Merged

REFACTOR-#5458: Make deploy functions in virtual_partition.py files private #5455

merged 1 commit into from
Dec 16, 2022

Conversation

anmyachev
Copy link
Collaborator

@anmyachev anmyachev commented Dec 16, 2022 •
edited
Loading

Signed-off-by: Anatoly Myachev anatoly.myachev@intel.com

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves REFACTOR: make deploy functions in virtual_partition.py files private #5458
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@anmyachev
REFACTOR-#0000: make deploy functions in virtual_partition.py files p…
52bb456 
…rivate

Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
@anmyachev anmyachev mentioned this pull request Dec 16, 2022
Merged
7 tasks
@anmyachev anmyachev changed the title REFACTOR-#0000: make deploy functions in virtual_partition.py files private REFACTOR-#5458: make deploy functions in virtual_partition.py files private Dec 16, 2022
@anmyachev anmyachev marked this pull request as ready for review December 16, 2022 15:27
@anmyachev anmyachev requested a review from a team as a code owner December 16, 2022 15:27
@YarShev YarShev changed the title REFACTOR-#5458: make deploy functions in virtual_partition.py files private REFACTOR-#5458: Make deploy functions in virtual_partition.py files private Dec 16, 2022
@YarShev YarShev merged commit 6d4ca59 into modin-project:master Dec 16, 2022
@anmyachev anmyachev deleted the make-deploy-func-private branch March 24, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YarShev YarShev YarShev approved these changes

Assignees
No one assigned
Labels
Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

REFACTOR: make deploy functions in virtual_partition.py files private
2 participants
@anmyachev @YarShev