Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOCS-#5463: Add jupyter tutorials for Modin on Unidist #5464

Merged
merged 13 commits into from
Jan 23, 2023
Merged

DOCS-#5463: Add jupyter tutorials for Modin on Unidist #5464

merged 13 commits into from
Jan 23, 2023

Conversation

Retribution98
Copy link
Collaborator

Signed-off-by: Kirill Suvorov kirill.suvorov@intel.com

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves Add jupyter tutorials for Modin on Unidist #5463
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@Retribution98 Retribution98 requested a review from a team as a code owner December 16, 2022 19:19
@YarShev YarShev changed the title DOCS-#5463: Update jupyter tutorials for Modin on Unidist DOCS-#5463: Add jupyter tutorials for Modin on Unidist Dec 16, 2022
@Retribution98 Retribution98 force-pushed the DOCS-5463 branch 7 times, most recently from 70383bb to 5a64929 Compare January 20, 2023 14:12
YarShev
YarShev reviewed Jan 20, 2023
View reviewed changes
.github/workflows/ci-notebooks.yml Outdated Show resolved Hide resolved
examples/tutorial/jupyter/README.md Outdated Show resolved Hide resolved
examples/tutorial/jupyter/execution/pandas_on_unidist/README.md Outdated Show resolved Hide resolved
examples/tutorial/jupyter/execution/pandas_on_unidist/README.md Outdated Show resolved Hide resolved
examples/tutorial/jupyter/execution/pandas_on_unidist/README.md Outdated Show resolved Hide resolved
examples/tutorial/jupyter/execution/pandas_on_unidist/test/test_notebooks.py Outdated Show resolved Hide resolved
examples/tutorial/jupyter/execution/pandas_on_unidist/README.md Outdated Show resolved Hide resolved
examples/tutorial/jupyter/execution/pandas_on_unidist/local/exercise_1.ipynb Outdated Show resolved Hide resolved
examples/tutorial/jupyter/execution/pandas_on_unidist/local/exercise_1.ipynb Outdated Show resolved Hide resolved
examples/tutorial/jupyter/execution/pandas_on_unidist/local/exercise_1.ipynb Show resolved Hide resolved
@Retribution98 Retribution98 force-pushed the DOCS-5463 branch 2 times, most recently from 110c1e1 to d298940 Compare January 20, 2023 18:40
@YarShev
Copy link
Collaborator

YarShev commented Jan 20, 2023

Rebase on current master to fix the failures in CI.

@Retribution98 Retribution98 force-pushed the DOCS-5463 branch 2 times, most recently from 30e6663 to c15849c Compare January 23, 2023 11:26
Retribution98 and others added 2 commits January 23, 2023 14:55
@Retribution98 @YarShev
Apply suggestions from code review
95224f5 
Co-authored-by: Iaroslav Igoshev <Poolliver868@mail.ru>
@Retribution98
Fix lint
7466050
YarShev
YarShev previously approved these changes Jan 23, 2023
View reviewed changes
@YarShev YarShev merged commit d394866 into modin-project:master Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YarShev YarShev YarShev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add jupyter tutorials for Modin on Unidist
2 participants
@Retribution98 @YarShev