Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REFACTOR-#3948: Use __constructor__ in DataFrame and Series classes #5485

Merged
merged 1 commit into from
Dec 20, 2022
Merged

REFACTOR-#3948: Use __constructor__ in DataFrame and Series classes #5485

merged 1 commit into from
Dec 20, 2022

Conversation

anmyachev
Copy link
Collaborator

@anmyachev anmyachev commented Dec 19, 2022 •
edited
Loading

Signed-off-by: Anatoly Myachev anatoly.myachev@intel.com

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves Subclassing modin.pandas Dataframe #3948
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@anmyachev
REFACTOR-modin-project#3948: use __constructor__ in DataFrame and Ser…
b0ee1e1 
…ies classes

Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
@anmyachev anmyachev marked this pull request as ready for review December 19, 2022 22:45
@anmyachev anmyachev requested a review from a team as a code owner December 19, 2022 22:45
@YarShev YarShev changed the title REFACTOR-#3948: use __constructor__ in DataFrame and Series classes REFACTOR-#3948: Use __constructor__ in DataFrame and Series classes Dec 20, 2022
@YarShev YarShev merged commit b541b6c into modin-project:master Dec 20, 2022
@YarShev YarShev mentioned this pull request Dec 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YarShev YarShev YarShev approved these changes

Assignees
No one assigned
Labels
Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Subclassing modin.pandas Dataframe
2 participants
@anmyachev @YarShev