Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PERF-#5660: Don't trigger axes computation when accessing cat.codes #5661

Merged
merged 1 commit into from
Feb 16, 2023
Merged

PERF-#5660: Don't trigger axes computation when accessing cat.codes #5661

merged 1 commit into from
Feb 16, 2023

Conversation

YarShev
Copy link
Collaborator

@YarShev YarShev commented Feb 15, 2023

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves Don't trigger axes computation when accessing cat.codes #5660
  • tests passing
  • module layout described at docs/development/architecture.rst is up-to-date

@YarShev YarShev force-pushed the dev/yigoshev-issue5660 branch 2 times, most recently from 7f2f2d6 to 7f5a117 Compare February 15, 2023 20:53
@YarShev
PERF-modin-project#5660: Don't trigger axes computation when accessin…
11cb47e 
…g cat.codes

Signed-off-by: Igoshev, Iaroslav <iaroslav.igoshev@intel.com>
@YarShev YarShev marked this pull request as ready for review February 15, 2023 23:34
@YarShev YarShev requested a review from a team as a code owner February 15, 2023 23:34
dchigarev
dchigarev approved these changes Feb 16, 2023
View reviewed changes
Copy link
Collaborator

@dchigarev dchigarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@dchigarev dchigarev merged commit 4c0f9d3 into modin-project:master Feb 16, 2023
@YarShev YarShev deleted the dev/yigoshev-issue5660 branch November 2, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dchigarev dchigarev dchigarev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't trigger axes computation when accessing cat.codes
2 participants
@YarShev @dchigarev