Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PERF-#5690: move read_callback from dispatchers into parsers #5689

Merged
merged 1 commit into from
Feb 22, 2023
Merged

PERF-#5690: move read_callback from dispatchers into parsers #5689

merged 1 commit into from
Feb 22, 2023

Conversation

anmyachev
Copy link
Collaborator

@anmyachev anmyachev commented Feb 21, 2023 •
edited
Loading

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves PERF: move read_callback from dispatchers into parsers #5690
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@anmyachev
REFACTOR-#0000: move 'read_callback' from dispatchers into parsers
e327f7e 
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
@anmyachev anmyachev changed the title REFACTOR-#0000: move read_callback from dispatchers into parsers PERF-#5690: move read_callback from dispatchers into parsers Feb 21, 2023
@anmyachev anmyachev marked this pull request as ready for review February 21, 2023 15:41
@anmyachev anmyachev requested a review from a team as a code owner February 21, 2023 15:41
@mvashishtha mvashishtha merged commit b113f47 into modin-project:master Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvashishtha mvashishtha mvashishtha approved these changes

Assignees
No one assigned
Labels
Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PERF: move read_callback from dispatchers into parsers
2 participants
@anmyachev @mvashishtha