Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REFACTOR-#5703: align DaskWrapper.deploy behavior with others #5701

Merged
merged 1 commit into from
Mar 3, 2023

Conversation

anmyachev
Copy link
Collaborator

@anmyachev anmyachev commented Feb 24, 2023

What do these changes do?

Allows instead of a function to pass distributed.Future into deploy (client.submit doesn't support this out of the box). There are no tests for this, but it is planned to use for #5678.

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves REFACTOR: align DaskWrapper.deploy behavior with others #5703
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
@anmyachev anmyachev changed the title REFACTOR-#0000: align 'DaskWrapper.deploy' behavior with others REFACTOR-#5703: align DaskWrapper.deploy behavior with others Feb 24, 2023
@anmyachev anmyachev marked this pull request as ready for review February 24, 2023 16:15
@anmyachev anmyachev requested a review from a team as a code owner February 24, 2023 16:15
@YarShev YarShev merged commit 272df05 into modin-project:master Mar 3, 2023
@anmyachev anmyachev deleted the align-deploy-beh branch March 3, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

REFACTOR: align DaskWrapper.deploy behavior with others
2 participants