Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REFACTOR-#6012: move experimental dispatchers under modin/experimental/... folder #6011

Merged
merged 6 commits into from
Apr 18, 2023
Merged

REFACTOR-#6012: move experimental dispatchers under modin/experimental/... folder #6011

merged 6 commits into from
Apr 18, 2023

Conversation

anmyachev
Copy link
Collaborator

@anmyachev anmyachev commented Apr 15, 2023 •
edited
Loading

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves move experimental dispatchers under modin/experimental/... folder #6012
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@anmyachev anmyachev changed the title REFACTOR-#0000: move experimental dispatchers under modin/experimental/... folder REFACTOR-#6012: move experimental dispatchers under modin/experimental/... folder Apr 15, 2023
@anmyachev anmyachev marked this pull request as ready for review April 15, 2023 20:02
@anmyachev anmyachev requested a review from a team as a code owner April 15, 2023 20:02
@anmyachev anmyachev requested a review from YarShev April 15, 2023 20:03
@anmyachev
REFACTOR-#0000: move experimental dispatchers under 'modin/experiment…
bbc8580 
…al' folder

Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
@anmyachev anmyachev force-pushed the move-experimental-dispatchers branch from 5731628 to bbc8580 Compare April 17, 2023 21:25
YarShev
YarShev reviewed Apr 18, 2023
View reviewed changes
docs/flow/modin/experimental/core/execution/dask/implementations/pandas_on_dask/index.rst Show resolved Hide resolved
docs/flow/modin/experimental/core/execution/dask/implementations/pandas_on_dask/io/index.rst Outdated Show resolved Hide resolved
modin/experimental/core/io/__init__.py Outdated

__all__ = [
"CSVGlobDispatcher",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"CSVGlobDispatcher",
"ExperimentalCSVGlobDispatcher",

Should this be experimental if we move it under experimental folder?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's not necessary. The main thing is not the name, but the fact that this functionality works only in experimental mode. However, I can change if you want.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I propose to add Experimental prefix.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@anmyachev
address review comments
f2b541d 
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
@anmyachev
return ':orphan:'
f5fbfcd 
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
@anmyachev
add flow/modin/experimental/core/io/index.rst
a0b9f05 
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
anmyachev and others added 2 commits April 18, 2023 19:40
@anmyachev @YarShev
Apply suggestions from code review
6c36943 
Co-authored-by: Iaroslav Igoshev <Poolliver868@mail.ru>
@anmyachev
rename 'CSVGlobDispatcher'
2b518e4 
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
@YarShev YarShev merged commit bbc7697 into modin-project:master Apr 18, 2023
@anmyachev anmyachev deleted the move-experimental-dispatchers branch April 18, 2023 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YarShev YarShev YarShev approved these changes

Assignees
No one assigned
Labels
Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

move experimental dispatchers under modin/experimental/... folder
2 participants
@anmyachev @YarShev