-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT-#6929: Implement Series.case_when in a distributed way #6972
Conversation
0fb5bcd
to
ac7668a
Compare
22b4687
to
932b6aa
Compare
8076725
to
3d568ab
Compare
242d2ff
to
b7b9587
Compare
I've not benchmarked, but it should be more efficient, because, if not cached, the same function is serialized multiple times for each partition on each call. |
There's no doubt that it's more efficient, but my point is that, in reality, nobody runs
This should actually be considered as a huge red flag, pointing out that there could be other unexpected side-effects of such implementation of caching with other engines.
Let's call |
Signed-off-by: Andrey Pavlenko <andrey.a.pavlenko@gmail.com>
Co-authored-by: Iaroslav Igoshev <Poolliver868@mail.ru>
Co-authored-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
Co-authored-by: Iaroslav Igoshev <Poolliver868@mail.ru>
@AndreyPavlenko, what else is required to be done in this PR? Please also resolve conflicts. |
b406652
to
181cc3e
Compare
181cc3e
to
d1b7fa4
Compare
d1b7fa4
to
7910d48
Compare
@anmyachev, @dchigarev, any comments? |
Co-authored-by: Anatoly Myachev <anatoliimyachev@mail.com>
What do these changes do?
flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
git commit -s
docs/development/architecture.rst
is up-to-date