-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TEST-#7076: Explicitly check for exceptions in test_map_metadata.py
#7077
Conversation
"Expected a 1D array, got an array with shape (3, 2)" | ||
) | ||
elif idx == 2: | ||
# Modin's exception message looks better, it's probably fine just leave it as is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you provide an example of the messages from Modin and pandas? Even if our message looks better, why should we not match pandas?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created new issues. Let’s decide it separately?
raising_exceptions = None | ||
if "float_nan_data" in request.node.callspec.id: | ||
# Modin's exception message looks better, it's probably fine just leave it as is | ||
raising_exceptions = False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same
@@ -1648,13 +1684,6 @@ def test___invert___bool(): | |||
df_equals(modin_result, pandas_result) | |||
|
|||
|
|||
def test___hash__(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dataframes are no longer hashable.
>>> import pandas as pd
>>> hash(pd.DataFrame([1,2,3,4]))
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
TypeError: unhashable type: 'DataFrame'
…_metadata.py' Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
@YarShev ready for review |
What do these changes do?
flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
git commit -s
test_map_metadata.py
#7076docs/development/architecture.rst
is up-to-date