Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REFACTOR-#7109: Remove the outdated aws_example.yaml file. #7110

Merged
merged 1 commit into from
Mar 20, 2024
Merged

REFACTOR-#7109: Remove the outdated aws_example.yaml file. #7110

merged 1 commit into from
Mar 20, 2024

Conversation

Retribution98
Copy link
Collaborator

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves Remove the outdated aws_example.yaml file. #7109
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@Retribution98
REFACTOR-modin-project#7109: Remove the outdated aws_example.yaml file.
3340d3a 
Signed-off-by: Kirill Suvorov <kirill.suvorov@intel.com>
@YarShev YarShev merged commit 1cbcdc2 into modin-project:master Mar 20, 2024
11 checks passed
anmyachev
anmyachev reviewed Mar 26, 2024
View reviewed changes
examples/tutorial/jupyter/execution/pandas_on_ray/cluster/modin-cluster.yaml
@@ -49,6 +49,7 @@ provider:
# How Ray will authenticate with newly launched nodes.
auth:
ssh_user: ubuntu
ssh_proxy_command: nc -X 5 -x proxy-ir.intel.com:1080 %h %p
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YarShev we should remove this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anmyachev anmyachev anmyachev left review comments

@YarShev YarShev YarShev approved these changes

@devin-petersohn devin-petersohn Awaiting requested review from devin-petersohn devin-petersohn is a code owner

@mvashishtha mvashishtha Awaiting requested review from mvashishtha mvashishtha is a code owner

@RehanSD RehanSD Awaiting requested review from RehanSD RehanSD is a code owner

@vnlitvinov vnlitvinov Awaiting requested review from vnlitvinov vnlitvinov is a code owner

@dchigarev dchigarev Awaiting requested review from dchigarev dchigarev is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove the outdated aws_example.yaml file.
3 participants
@Retribution98 @YarShev @anmyachev