-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REFACTOR-#7105: Deprecate 'cfg.RangePartitioningGroupby' #7161
Conversation
@@ -775,16 +791,24 @@ def _sibling(cls) -> type[EnvWithSibilings]: | |||
) | |||
|
|||
|
|||
class RangePartitioning(EnvironmentVariable, type=bool): | |||
def use_range_partitioning_groupby() -> bool: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the technique of making RangePartitioning
and RangePartitioningGroupby
siblings (as we did it before with ExperimentalGroupbyImpl
) won't work here, since we don't want for them to actually share the same value (if they would be siblings, RangePartitioningGroupby.put(True)
would enable other range-part implementations, not only groupby) that's why introducing this hacky helper function for now
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@dchigarev should we merge the PR before the next release or after? |
I think we should merge it before release cc @YarShev ? |
What do these changes do?
Deprecate
cfg.RangePartitioningGroupby
in favor ofcfg.RangePartitioning
flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
git commit -s
cfg.RangePartitioning
instead ofcfg.RangePartitioningGroupby
in docs #7105docs/development/architecture.rst
is up-to-date