TEST-#7166: Fix HDF tests in CI #7167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
anmyachev
requested review from
devin-petersohn,
mvashishtha,
RehanSD,
YarShev,
vnlitvinov,
dchigarev and
a team
as code owners
YarShev
reviewed
Apr 10, 2024
| @@ -31,6 +31,7 @@ dependencies: | |||
| - sqlalchemy>=2.0.0 | |||
| - pandas-gbq>=0.19.0 | |||
| - pytables>=3.8.0 | |||
| - c-blosc2<=2.14.1 | |||
There was a problem hiding this comment.
Should we also update requirements-dev.txt?
There was a problem hiding this comment.
I think this is not necessary, we just need the tests in CI to work as quickly as possible, I believe that either pytables or c-blosc2 will release their new patches to make everything work (fast enough). Also, I'm not sure if this error is present when installing using pip.
7 tasks
YarShev
approved these changes
Apr 11, 2024
7 tasks
anmyachev
added a commit
to anmyachev/modin
that referenced
this pull request
Apr 11, 2024
)" This reverts commit 975b32c. Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
YarShev
pushed a commit
that referenced
this pull request
Apr 12, 2024
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Blosc/c-blosc2#601
flake8 modin/ asv_bench/benchmarks scripts/doc_checker.pyblack --check modin/ asv_bench/benchmarks scripts/doc_checker.pygit commit -sdocs/development/architecture.rstis up-to-date