Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX-#7102: Remove enable_api_only mode in modin logging #7194

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

arunjose696
Copy link
Collaborator

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves Remove enable_api_only mode in modin logging #7102
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

Signed-off-by: arunjose696 <arunjose696@gmail.com>
@@ -169,7 +169,7 @@ def configure_logging() -> None:
"modin.logger.default",
job_id,
"trace",
LogLevel.INFO if LogMode.get() == "enable_api_only" else LogLevel.DEBUG,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we losing the ability to configure the debug level?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes the ability to configure would be lost, however the lower-level functionality would be made debug level (instead of info) in a further PR #7184

@YarShev
Copy link
Collaborator

YarShev commented Apr 17, 2024

@anmyachev, any other comments?

@anmyachev anmyachev merged commit 615f975 into modin-project:main Apr 17, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove enable_api_only mode in modin logging
3 participants