Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEAT-#7195: Implement DataFrame API standard #7196

Closed
wants to merge 13 commits into from
Closed

FEAT-#7195: Implement DataFrame API standard #7196

wants to merge 13 commits into from

Conversation

anmyachev
Copy link
Collaborator

@anmyachev anmyachev commented Apr 17, 2024 •
edited
Loading

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves Implement DataFrame API standard #7195
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@anmyachev
FEAT-modin-project#6890: add consortium standard entrypoint
f6b2f61 
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
@anmyachev
fixes
2fd81dc 
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
@anmyachev
add missed pytest call
fdc21a6 
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
@anmyachev
FEAT-#0000: Implement DataFrame API standard
38630e7 
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
@anmyachev
remove 'dataframe-api-compat'
a11bf8d 
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
@anmyachev
add license headers
0a7a637 
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
@anmyachev
fix
116a737 
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
@anmyachev
fix docstrings
5f7730b 
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
@anmyachev anmyachev mentioned this pull request Apr 17, 2024
Closed
7 tasks
@anmyachev
Merge branch 'main' of https://github.com/modin-project/modin into da…
9000626 
…taframe-api-impl
@anmyachev
add missing files
228d922 
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 17, 2024
View reviewed changes
modin/dataframe_api_standard/column_object.py Dismissed Show dismissed Hide dismissed
modin/dataframe_api_standard/column_object.py Dismissed Show dismissed Hide dismissed
modin/dataframe_api_standard/dataframe_object.py Dismissed Show dismissed Hide dismissed
modin/dataframe_api_standard/dataframe_object.py Dismissed Show dismissed Hide dismissed
modin/dataframe_api_standard/dataframe_object.py Dismissed Show dismissed Hide dismissed
modin/tests/dataframe_api_standard/integration/persistedness_test.py
df = integer_dataframe_1(library)
df = df.persist()
df1 = df.filter(df.col("a") > 1)
df2 = df.filter(df.col("a") <= 1)

Check notice

Code scanning / CodeQL

Unused local variable Note test

Variable df2 is not used.
modin/tests/dataframe_api_standard/integration/persistedness_test.py
df1 = df.filter(df.col("a") > 1)
df2 = df.filter(df.col("a") <= 1)

df1 = df1.persist()

Check notice

Code scanning / CodeQL

Unused local variable Note test

Variable df1 is not used.
modin/tests/dataframe_api_standard/namespace/column_from_sequence_test.py
kwargs: dict[str, Any],
) -> None:
df = integer_dataframe_1(library)
ns = df.__dataframe_namespace__()

Check warning

Code scanning / CodeQL

Variable defined multiple times Warning test

This assignment to 'ns' is unnecessary as it is
redefined
Loading
before this value is used.
modin/tests/dataframe_api_standard/integration/persistedness_test.py
pytest.skip("TODO: enable for modin")
df1 = integer_dataframe_1(library)
df2 = integer_dataframe_2(library)
ns = df1.__dataframe_namespace__()

Check warning

Code scanning / CodeQL

Variable defined multiple times Warning test

This assignment to 'ns' is unnecessary as it is
redefined
Loading
before this value is used.
modin/tests/dataframe_api_standard/namespace/to_array_object_test.py

def test_column_to_array_object(library: BaseHandler) -> None:
col = integer_dataframe_1(library).col("a")
result = np.asarray(col.persist().to_array())

Check warning

Code scanning / CodeQL

Variable defined multiple times Warning test

This assignment to 'result' is unnecessary as it is
redefined
Loading
before this value is used.
@anmyachev
fixes
bb7818e 
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
@anmyachev
fix isort
409e6d7 
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
@anmyachev
fix imports
0ab5ef7 
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
@anmyachev anmyachev marked this pull request as ready for review April 17, 2024 18:07
@anmyachev anmyachev marked this pull request as draft April 18, 2024 14:36
@anmyachev
Copy link
Collaborator Author

Closed in favour of #7216

@anmyachev anmyachev closed this Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devin-petersohn devin-petersohn Awaiting requested review from devin-petersohn devin-petersohn is a code owner

@mvashishtha mvashishtha Awaiting requested review from mvashishtha mvashishtha is a code owner

@RehanSD RehanSD Awaiting requested review from RehanSD RehanSD is a code owner

@YarShev YarShev Awaiting requested review from YarShev YarShev is a code owner

@vnlitvinov vnlitvinov Awaiting requested review from vnlitvinov vnlitvinov is a code owner

@dchigarev dchigarev Awaiting requested review from dchigarev dchigarev is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement DataFrame API standard
1 participant
@anmyachev