-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT-#7265: Automatic publication of Modin wheel to PyPI #7262
Conversation
1b93e19
to
830a735
Compare
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
486a41a
to
3ebe973
Compare
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
Co-authored-by: Devin Petersohn <devin.petersohn@snowflake.com>
runs-on: ubuntu-latest | ||
|
||
steps: | ||
- uses: actions/checkout@v4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should checkout Modin with fetch_depth: 0
, otherwise only a latest commit is fetched.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should have tagged wheels, otherwise we might get untagged ones.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is possible the latest commit is not the tagged commit, so I think @YarShev is correct. Additionally, we may want to check out the latest tag to ensure we only upload tagged releases.
It would be good to also have a check that ensures that the release name is correct, so it doesn't upload a bad release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will it be better to use fetch-tags:
option?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes that would be good, but we should also git checkout
the latest tag to ensure we build the correct release. It seems like we still need fetch-depth:0
for fetch-tags
to work properly: actions/checkout#1471
Co-authored-by: Devin Petersohn <devin-petersohn@users.noreply.github.com>
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
Co-authored-by: Devin Petersohn <devin-petersohn@users.noreply.github.com>
run: git checkout $(git describe --tags "$(git rev-list --tags --max-count=1)") | ||
if: github.event_name == 'push' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my suggestion I swapped the order of these 😢
run: git checkout $(git describe --tags "$(git rev-list --tags --max-count=1)") | |
if: github.event_name == 'push' | |
if: github.event_name == 'push' | |
run: git checkout $(git describe --tags "$(git rev-list --tags --max-count=1)") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my suggestion I swapped the order of these 😢
Actually, I've adjusted your suggestion a bit to make the style similar to what is used in ci.yml
:) Does it make sense?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, is this valid too? If so I'm okay to merge this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, is this valid too?
yes
@anmyachev, we should also have updated the release docs. |
What do these changes do?
flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
git commit -s
docs/development/architecture.rst
is up-to-date